Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Configure decryption trustRequirement based on config flag #3358

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BillCarsonFr
Copy link
Member

Pull Request Checklist

Depends on matrix-org/matrix-rust-sdk#4046

Part of https://github.com/element-hq/crypto-internal/issues/354

For now the new decryption errors will show as regular ones (waiting for this message), a following PR will fix that once the sdk has support for different UTD errors

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@BillCarsonFr BillCarsonFr added the pr-feature for a new feature label Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e8edf7f

Copy link

codecov bot commented Oct 2, 2024

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

@BillCarsonFr BillCarsonFr force-pushed the valere/crypto_only_signed_decryption_trust_req branch from 161c2a3 to e8edf7f Compare October 3, 2024 07:13
Copy link

sonarcloud bot commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant