Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the core logic in LoginScreenCoordinator into the ViewModel. #3348

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Move the core logic in LoginScreenCoordinator into the ViewModel. #3348

merged 3 commits into from
Oct 1, 2024

Conversation

pixlwave
Copy link
Member

This PR does the same for the LoginScreenCoordinator as #3342 did for the ServerSelectionCoordinator, moving all the logic into the View Model to match the rest of the app.

@pixlwave pixlwave requested a review from a team as a code owner September 30, 2024 09:04
@pixlwave pixlwave requested review from stefanceriu and removed request for a team September 30, 2024 09:04
@pixlwave pixlwave added the pr-misc for other changes label Sep 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against ddb691b

@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
838 1 837 0
View the full list of 1 ❄️ flaky tests 
RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 25.32% (Passed 59 times, Failed 20 times)

Stack Traces | 13.5s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Velin92
Velin92 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits

@stefanceriu stefanceriu removed their request for review September 30, 2024 10:43
@pixlwave pixlwave changed the title Move the core logic LoginScreenCoordinator into the ViewModel. Move the core logic in LoginScreenCoordinator into the ViewModel. Sep 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pixlwave pixlwave merged commit 268d9f7 into develop Oct 1, 2024
7 checks passed
@pixlwave pixlwave deleted the doug/login-view-model branch October 1, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Velin92 Velin92 Velin92 approved these changes

Assignees
No one assigned
Labels
pr-misc for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @Velin92