Start fixing flakey tests ❄️

[pixlwave]

First round of changes and a non-failing run. Probably best to merge this so the Preview Tests are more stable and look at other flakey unit tests separately.

The PR has individual commits for each change.

[github-actions]

	Warnings
⚠️	Please provide a description for this PR.
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 134b8f4

[codecov]

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
831	3	828	0

View the top 2 failed tests by shortest run time

UserIndicatorControllerTests testChainedPresentation()

Stack Traces | 2.55s run time

XCTAssertEqual failed: ("3") is not equal to ("2") (.../UnitTests/Sources/UserIndicatorControllerTests.swift:61)

CompletionSuggestionServiceTests testUserSuggestionsIncludingAllUsers()

Stack Traces | 12.2s run time

Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

View the full list of 1 ❄️ flaky tests

PreviewTests test_timelineItemBubbledStylerView()

Flake rate in main: 35.71% (Passed 36 times, Failed 20 times)

Stack Traces | 13.1s run time

failed - Snapshot "Pinned messages" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineItemBubbledStylerView-iPhone-16-en-GB.Pinned-messages.png"
@+
"file:.../tmp/PreviewTests/test_timelineItemBubbledStylerView-iPhone-16-en-GB.Pinned-messages.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8688965 is less than required 1.0
The lowest perceptual color precision 0.18624997 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[stefanceriu]

Very very nice! Fingers crossed 🤞