Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on develop #3585

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix tests on develop #3585

merged 2 commits into from
Oct 2, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 2, 2024

Content

Fix test compilation, due to #3554 being merged without being up to date.

Motivation and context

Fix compilation.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner October 2, 2024 19:31
@bmarty bmarty requested review from jmartinesp and removed request for a team October 2, 2024 19:31
@bmarty bmarty added the PR-Misc For other changes label Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AADzx1

Copy link

sonarcloud bot commented Oct 2, 2024

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (ee7e5b8) to head (55c11e9).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3585      +/-   ##
===========================================
+ Coverage    80.41%   80.74%   +0.32%     
===========================================
  Files         1773     1762      -11     
  Lines        44678    42395    -2283     
  Branches      5219     5133      -86     
===========================================
- Hits         35930    34233    -1697     
+ Misses        6961     6387     -574     
+ Partials      1787     1775      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 9f7e4d5 into develop Oct 2, 2024
30 checks passed
@bmarty bmarty deleted the feature/bma/fixTests branch October 2, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant