Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AppBindings to XAppBindings #3518

Closed
wants to merge 1 commit into from

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 23, 2024

Rename AppBindings to XAppBindings to attempt to fix reproducible build issue

Attempt to fix difference reported here: #3420 (comment)

If this does not work, we may want to move XAppBindings to a sub package...

@bmarty bmarty requested a review from a team as a code owner September 23, 2024 09:29
@bmarty bmarty requested review from jmartinesp and removed request for a team September 23, 2024 09:29
@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 23, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 23, 2024
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GsrqZy

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (349e2bb) to head (a578348).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...c/main/kotlin/io/element/android/x/MainActivity.kt 0.00% 1 Missing ⚠️
...lement/android/x/initializer/TracingInitializer.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3518   +/-   ##
========================================
  Coverage    82.67%   82.67%           
========================================
  Files         1731     1731           
  Lines        40863    40863           
  Branches      4971     4971           
========================================
  Hits         33785    33785           
  Misses        5315     5315           
  Partials      1763     1763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of sad we have to workaround this, but let's try it out 🥲 .

Copy link

sonarcloud bot commented Sep 23, 2024

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this doesn't fix the issue for reproducible builds, so there's no point in the rename... Thanks for trying to fix it, though.

@bmarty bmarty closed this Sep 23, 2024
@bmarty bmarty deleted the feature/bma/tryToFixReproducibleBuild branch September 24, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants