Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Kotlin 2.0 with Anvil #3065

Draft
wants to merge 24 commits into
base: develop
Choose a base branch
from
Draft

Test Kotlin 2.0 with Anvil #3065

wants to merge 24 commits into from

Conversation

jmartinesp
Copy link
Member

This is a draft PR to check how it behaves in the CI.

Copy link
Contributor

github-actions bot commented Jun 21, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/RvSQ4z

Copy link

sonarcloud bot commented Jun 21, 2024

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Aug 12, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 17.94872% with 64 lines in your changes missing coverage. Please review.

Project coverage is 81.58%. Comparing base (20d0278) to head (45f8e82).
Report is 10 commits behind head on develop.

Files Patch % Lines
...element/android/x/licenses/AssetLicensesFetcher.kt 0.00% 37 Missing ⚠️
...ment/android/x/licenses/DependenciesDetailsNode.kt 0.00% 24 Missing ⚠️
...droid/x/licenses/OssOpenSourcesLicensesProvider.kt 0.00% 1 Missing ⚠️
...c/main/kotlin/io/element/android/x/di/AppModule.kt 0.00% 1 Missing ⚠️
...ent/android/features/joinroom/impl/JoinRoomNode.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3065      +/-   ##
===========================================
- Coverage    82.56%   81.58%   -0.98%     
===========================================
  Files         1662     1673      +11     
  Lines        38992    39921     +929     
  Branches      4724     4732       +8     
===========================================
+ Hits         32192    32570     +378     
- Misses        5133     5760     +627     
+ Partials      1667     1591      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElementBot
Copy link
Collaborator

Fails
🚫

Please add a PR- label to categorise the changelog entry.

Warnings
⚠️

You have made changes to a file containing a @Preview annotated function but its package name prefix is not included in the ComposablePreviewProvider.
Packages missing in tests/uitests/src/test/kotlin/base/ComposablePreviewProvider.kt:

  • extension
Messages
📖 This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
📖 Sign-off not required, allow-list

Generated by 🚫 dangerJS against 9452445

Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants