Reword message for failure to join/find room #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message originally focused on the old feature of being able to create a room with a custom URL. Instead, be more direct & say that the current URL is for an inaccessible room. This new message is based on what Element Web says for this scenario.
|
Partially addresses #2348. The issue of a knock button sometimes appearing for private rooms is likely caused by a stale room membership cache, and won't be addressed by this PR. |
|
Also note that the condition for showing this message is an error response in getting the room summary, which returns |
toger5
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message originally focused on the old feature of being able to create a room with a custom URL. Instead, be more direct & say that the current URL is for an inaccessible room.
This new message is based on what Element Web says for this scenario.