Add missing semantic tokens for critical & accent buttons

[nadonomy]

We're missing:

1. A token for critical/pressed buttons
2. Accent button tokens

However when I went to add I noticed inconsistencies with how we've defined tokens:

You can see we have:

bg/action/primary/rest
bg/action/primary/hovered
bg/action/primary/pressed
bg/action/secondary/rest
bg/action/secondary/hovered
bg/action/secondary/pressed

bg/critical/primary
bg/critical/hovered

when I think instead we should have:

bg/action/primary/rest
bg/action/primary/hovered
bg/action/primary/pressed
bg/action/secondary/rest
bg/action/secondary/hovered
bg/action/secondary/pressed
bg/action/critical/rest
bg/action/critical/hovered
bg/action/critical/pressed
bg/action/accent/rest
bg/action/accent/hovered
bg/action/accent/pressed

Open questions:

1. Does anyone disagree with unifying the action tokens as above?
2. Should I deprecate the misplaced bg/critical tokens in Token Studio? If so, will that introduce any breaking changes?

[pixlwave]

For 1. Would it be fair to say we might have a critical background for something that isn't a button?

[nadonomy]

For 1. Would it be fair to say we might have a critical background for something that isn't a button?

Yep! I didn't note them in this issue but we also have:

bg/critical/subtle
bg/critical/subtle-hovered
border/critical/primary
border/critical/hovered
border/critical/subtle

which we use for stuff like critical alerts.

[nadonomy]

Separately we also have:

bg/success/subtle
bg/info/subtle

So instead, I think we should unify overall to this and then re-map:

bg/action/primary/rest
bg/action/primary/hovered
bg/action/primary/pressed
bg/action/secondary/rest
bg/action/secondary/hovered
bg/action/secondary/pressed
bg/action/critical/rest
bg/action/critical/hovered
bg/action/critical/pressed
bg/action/accent/rest
bg/action/accent/hovered
bg/action/accent/pressed

bg/critical/subtle
bg/success/subtle
bg/info/subtle

this would mean deprecating bg/critical/subtle-hovered too, but it's the only subtle-hovered token and intuitively I'm not sure where we'd need it.

[pixlwave]

I guess I'm not sure I see the benefit of defining a difference between "critical" and "critical as an action". E.g. we have text/critical/primary would we additionally need a text/action/critical/primary for when the text is a secondary/tertiary button?