Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure our web build stays compatible with React 17 #287

Open
robintown opened this issue Dec 13, 2023 · 0 comments
Open

Make sure our web build stays compatible with React 17 #287

robintown opened this issue Dec 13, 2023 · 0 comments
Labels
A-Developer-Experience P-Web Platform Web T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@robintown
Copy link
Member

Some of our projects use React 18, while others like Element Web are stuck on React 17. As long as we need to support React 17, we should enforce in CI that our Compound Web builds stay compatible, because this is delicate to maintain.

Separately, it would also be worth looking into whether there's some less painful way for a component library to support both React versions. Radix Primitives seems to have this figured out? But not sure what their secret to success is.
@robintown robintown added P-Web Platform Web A-Developer-Experience T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience P-Web Platform Web T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robintown