Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative units for layout properties #283

Open
janogarcia opened this issue Nov 24, 2023 · 0 comments
Open

Use relative units for layout properties #283

janogarcia opened this issue Nov 24, 2023 · 0 comments
Labels
P-Web Platform Web T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@janogarcia
Copy link
Contributor

As discussed internally, use relative units so that components can scale based on the base font size.

At component level

  • Make sure we use rem for font size values and relative units for other typesetting properties (line height, letter spacing, etc.)
  • Use rem instead of px for layout (spacing, min height, etc.). Exceptions to this rule may apply (setting a border to 1px that we don't want to scale with font size).

At the application level

These tasks are out of the scope of Compound components, but we can provide guidelines to be followed at the application level.

@kerryarchibald kerryarchibald added P-Web Platform Web T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-Web Platform Web T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

2 participants