Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iOS 18 on our introspections #104

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Conversation

pixlwave
Copy link
Member

Also make them public so we have less overall as it would result in duplicate code across multiple projects if we decided something shouldn't happen on a specific iOS version.

Also includes the latest Renovate branch.

@pixlwave pixlwave requested a review from a team as a code owner September 10, 2024 10:25
@pixlwave pixlwave requested review from stefanceriu and removed request for a team September 10, 2024 10:25
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.27%. Comparing base (6acc9d7) to head (c575377).

Files with missing lines Patch % Lines
...Compound/Extensions/PlatformVersionPredicate.swift 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   96.44%   96.27%   -0.17%     
==========================================
  Files          18       18              
  Lines        1153     1155       +2     
==========================================
  Hits         1112     1112              
- Misses         41       43       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pixlwave pixlwave merged commit 22f9d80 into main Sep 10, 2024
2 checks passed
@pixlwave pixlwave deleted the doug/introspect-18 branch September 10, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants