Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Defend Workflows][Reusable integrations] Handling resuable integrations on endpoint onboarding page (#193518) #194617

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ons on endpoint onboarding page (elastic#193518)

## Summary

During onboarding on the Endpoint list page, if the user already created
at least one Elastic Defend integration, we show this screen (original):
<img width="400" alt="image"
src="https://github.com/user-attachments/assets/98f04002-7c18-48bf-8b29-a4ad6113385c">

Due to the new enterprise level feature added by Fleet team, the
reusable integrations, now an integration policy can be assigned **zero,
one or more agent policies**, and this PR's goal is to update this
onboarding screen to tackle these changes.

### One integration is added to more than one Agent Policies
When creating/editing an integration, it can be added to more than one
Agent Policies:

<img width="600" alt="image"
src="https://github.com/user-attachments/assets/f0982e28-11b0-4aef-a059-6c952e0e33b7">

#### ✅ Solution for usecase
To be able to select where to enroll an Agent, now they are listed as
`Package policy - Agent policy` pairs.
<img width="600" alt="image"
src="https://github.com/user-attachments/assets/c82d70ed-5b87-43b5-ab16-3c4549373b32">

### Some integrations are not added to an Agent Policy
<img width="400" alt="image"
src="https://github.com/user-attachments/assets/108ccd78-d019-42ca-a92a-905344172d09">

#### ✅ Solution for usecase
A new callout is added to indicate to the user that there are some
integrations that cannot be deployed to an Agent.

<img width="600" alt="image"
src="https://github.com/user-attachments/assets/3bedc56b-70a3-4f4f-9881-e91ae458cadf">

Clicking on the Integrations opens their editing page in a new tab.
Clickin on the 'Elastic Defend Integration policies' opens the Defend
integration's policies tab in a new browser tab.

### None of the integrations are added to an Agent Policy
<img width="300" alt="image"
src="https://github.com/user-attachments/assets/39fd2efc-2a96-4109-9311-b666bd44ca1f">

#### ✅ Solution for usecase
Another 'warning' callout is displayed indicating that there are no
usable integrations. This, combined with the other callout hopefully
help the user to go forward.

<img width="600" alt="image"
src="https://github.com/user-attachments/assets/78efc1ea-dd3e-4aff-bd67-b1e37a2508e1">

### RBAC
In case the user doesn't hold the required privileges, the same screen
is displayed as when there are no hosts and no policies, or there are
policies but no hosts. Just as before.
<img width="600" alt="image"
src="https://github.com/user-attachments/assets/814f460d-7e17-49a7-8337-9cf1f8a8f0ef">

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 8eceb0d)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.5MB 20.5MB +5.0KB
Unknown metric groups

References to deprecated APIs

id before after diff
securitySolution 457 451 -6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @gergoabraham

@kibanamachine kibanamachine merged commit c601fdf into elastic:8.x Oct 1, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants