Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up cloud_chat #194571

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Oct 1, 2024

Summary

Close https://github.com/elastic/kibana-team/issues/1017

This PR removes the unused Cloud Chat functionality from Kibana. The chat was not used for some time. Moreover, we've seen some issues with it where users saw it when it wasn't expected. Given the absence of automated tests and the fact that the feature is no longer needed, we are removing it to improve the overall maintainability and reliability of the codebase. This will also decrease the amount of code loaded for trial users of Kibana in cloud making the app slightly faster.

Copy link

github-actions bot commented Oct 1, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@Dosant Dosant changed the title clean up cloud chat Clean up cloud_chat Oct 1, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudChat 35 - -35

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudChat 7.3KB - -7.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudChat 14.1KB - -14.1KB
Unknown metric groups

async chunk count

id before after diff
cloudChat 2 - -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 1, 2024
@Dosant Dosant marked this pull request as ready for review October 1, 2024 16:36
@Dosant Dosant requested review from a team as code owners October 1, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants