Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving to async init #194567

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Moving to async init #194567

wants to merge 2 commits into from
+28 −14

Conversation

tiansivive
Copy link
Contributor

Summary

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 1, 2024 •
edited
Loading

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!

tiansivive
tiansivive commented Oct 1, 2024
View reviewed changes
...ugins/security_solution/server/lib/entity_analytics/entity_store/entity_store_data_client.ts
`Error initializing entity store for ${entityType}: ${err.message}`
);

this.engineClient.update(definition.id, ENGINE_STATUS.ERROR);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if this fails?
The engine status will be stuck at installing. How do we recover/show silent errors like this?

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 1, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #93 / Entity Analytics - Entity Store @ess @serverless @skipInServerlessMKI Entity Store Engine APIs get and list get should return the host entity engine
  • [job] [logs] FTR Configs #105 / Entity Analytics - Entity Store @ess @serverless @skipInServerlessMKI Entity Store Engine APIs get and list get should return the host entity engine
  • [job] [logs] FTR Configs #93 / Entity Analytics - Entity Store @ess @serverless @skipInServerlessMKI Entity Store Engine APIs get and list get should return the host entity engine
  • [job] [logs] FTR Configs #105 / Entity Analytics - Entity Store @ess @serverless @skipInServerlessMKI Entity Store Engine APIs get and list get should return the host entity engine

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.5MB 20.5MB +8.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiansivive @elasticmachine @kibana-ci @kibanamachine