Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding package.vendor to ECS package mapping #2206

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

epicsilence99
Copy link

Adding an ECS mapping for package that maps to package.vendor to accompany other fields such as package.name and package.version

@epicsilence99 epicsilence99 requested a review from a team as a code owner May 1, 2023 15:23
Adding ECS field mapping for package with package.vendor
@epicsilence99
Copy link
Author

This is related to feature enhancement requested here:
#2203

@ebeahan
Copy link
Member

ebeahan commented May 5, 2023

@lkuik can you elaborate a bit more about how you plan to use a package.vendor field?

My first thought is many packages aren't authored or maintained by a vendor, but instead by an individual, group of maintainers, project, etc. I took a brief look across different package registries and package formats (npm, pypi, gem, deb, rpm), and I'm not seeing consistent convention.

@ebeahan
Copy link
Member

ebeahan commented May 5, 2023

The tests are failing because because make needs run and the generated files commited.

@epicsilence99
Copy link
Author

epicsilence99 commented May 5, 2023

@lkuik can you elaborate a bit more about how you plan to use a package.vendor field?

My first thought is many packages aren't authored or maintained by a vendor, but instead by an individual, group of maintainers, project, etc. I took a brief look across different package registries and package formats (npm, pypi, gem, deb, rpm), and I'm not seeing consistent convention.

That's a great point @ebeahan
I guess I was thinking more application than package in this context, and perhaps that was my mistake.
I didn't see anything for application ECS mapping so was thinking package was the more appropriate ECS field mapping to use.
So not just more open sourced focus (community maintained), but also thinking broader context of applications from security tools that can detect applications/packages too. So if that's not what this package fields for ECS was intended for may need to rethink where that would actually fit.

@epicsilence99
Copy link
Author

Just following up if you saw my post @ebeahan in regards to where I was coming from, was looking to get your thoughts based on that.

@github-actions
Copy link

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Stale issues and pull requests label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants