Testing KUKSA Server Unittest #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now trying to use 4 everywhere
lukasmittag
reviewed
Aug 1, 2023
| - ".github/workflows/kuksa_val_unittest.yml" | ||
| - "kuksa-val-server/**" | ||
| - "kuksa_certificates/**" | ||
| - "proto/**" |
There was a problem hiding this comment.
this is the same issue as in #611 not the right location to look for proto files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns unit-tests with other triggers and now it works. It also removes explicit install of gRPC and Boost. That is included from cmake so not needed. The old warning that it might be needed for "older" versions of cmake shall likely not be relevant any longer, at least not if we assume that Ubuntu 20 or newer is used.
Still the build takes time. A possible remedy for CI could be to join both builds to the same so we do not need to install boost and gRPC twice.
Now also using 4 threads (
-j 4in all builds)