Enable buffer pooling settings with a SSL configurable option

[franz1981]

SSL JDK can really be a memory hell, see netty/netty#14208: using unpooled buffers means trouble - but still there are users which "maybe" want to keep things as they are.

I've created an "hidden" property (which should become the default in vertx 5 really...) to have forcibly pooling of heap buffers using JDK SSL, but, by default it will keep the behaviour as it is.

[franz1981]

@cescoffier and @vietj PTAL

I've added some asserts to make it existing tests to fail and make sure the invariant I'm assuming for SSL on vertx are correct.

[franz1981]

@cescoffier this is key for both https and vertx sql client - cause the latter will rely heavily on it for the reactive sql drivers (both mysql and postgres AFAIK) -

@tsegismont AFAIK vertx sql driver should rely on NetClientImpl e.g. https://github.com/eclipse-vertx/vertx-sql-client/blob/master/vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/ConnectionFactoryBase.java#L45
hence I would expect that the changes on NetClientImpl's allocator should just do "the right thing", wdyt?

[franz1981]

After talking with @cescoffier I'm changing this back to use a specific option to enable this feature.

[franz1981]

PTAL @vietj

I've added some test (I could improve thsi further) - but it is not clear to me yet the role of https://vertx.io/docs/apidocs/io/vertx/core/http/HttpClientOptions.html#setSsl-boolean-

And indeed it seems that ssl, whilst false can still build a JDK EngineConfig, see

vert.x/src/main/java/io/vertx/core/net/impl/SSLHelper.java

Line 341 in 0fca2ca

sslContextFactorySupplier = Future.succeededFuture(new EngineConfig(SslProvider.JDK, sslOptions, () -> new DefaultSslContextFactory(SslProvider.JDK, false), SSLEngineOptions.DEFAULT_USE_WORKER_POOL));

can you help me to understand what's ssl is meant to configure and how to use it?

[franz1981]

@cescoffier not yet perfect but decent enough to make sure the default behaviour is still the same
I need to wait till this is merged to add some CI run which enable both this and the unified allocator changes at #5292 , which is ready for being reviewed too (by @vietj )

[franz1981]

@tsegismont
I need you here bud: how do I benefit from this change into vert-x sql client?
How we can consume it for vert-x sql client too into Quarkus?

i.e. Here I need users to set https://vertx.io/docs/apidocs/io/vertx/core/net/TCPSSLOptions.html#setSsl-boolean- and https://vertx.io/docs/apidocs/io/vertx/core/net/TCPSSLOptions.html#setSslEngineOptions-io.vertx.core.net.SSLEngineOptions- (passing a JDK SSL option which enable heap buffer pooling), in order to made vertx to do the "right" thing and avoid quarkusio/quarkus#41880 (comment) to happen.