Remove bind options when creating a volume type #12177
Open
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
reviewed
Oct 1, 2024
pkg/compose/create.go
Outdated
Comment on lines
316
to
317
| logrus.Infof("host - binds %+v", binds) | ||
| logrus.Infof("host - mounts %+v", mounts) |
ndeloof
reviewed
Oct 1, 2024
jhrotko
force-pushed
the
remove-bind-mount-in-volume
branch
2 times, most recently
from
4d5ee2c
to
675fc65
Compare
Signed-off-by: Joana Hrotko <[email protected]>
jhrotko
force-pushed
the
remove-bind-mount-in-volume
branch
from
675fc65
to
29280a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Cleanup to remove bind options when creating a volume type. Tried to reproduce from original issue and it seems the root cause was fixed meanwhile.
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
