Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 1.x - nltk upgrade, use nltk.download('punkt_tab') #8254

Closed
wants to merge 2 commits into from

Conversation

vblagoje
Copy link
Member

@vblagoje vblagoje commented Aug 20, 2024

@vblagoje vblagoje requested review from a team as code owners August 20, 2024 08:49
@vblagoje vblagoje requested review from dfokina and anakin87 and removed request for a team August 20, 2024 08:49
@vblagoje vblagoje changed the base branch from main to v1.26.x August 20, 2024 08:49
@vblagoje vblagoje changed the title chore: Nltk update chore: 1.x - nltk upgrade, use nltk.download('punkt_tab') Aug 20, 2024
@vblagoje
Copy link
Member Author

@julian-risch this one should go on 1.x branch in addition to 1.26.x - is that correct?
@anakin87 CI is not being run because base is not 1.x?

@vblagoje vblagoje changed the base branch from v1.26.x to v1.x August 20, 2024 08:56
@vblagoje vblagoje changed the base branch from v1.x to v1.26.x August 20, 2024 08:57
@anakin87
Copy link
Member

1.x branch is dead, I think
IDK why tests are not running

@vblagoje
Copy link
Member Author

@silvanocerza do you have a suggestion what to do here? More precisely:

  • Should we add this one to v1.x branch and then cherry-pick to v1.26.x, or just v1.26.x directly?
  • Any idea why CI is not running on v1.26.x PRs?

@vblagoje
Copy link
Member Author

I got my answer with #8255 thanks all

@vblagoje vblagoje marked this pull request as draft August 20, 2024 09:26
@vblagoje vblagoje marked this pull request as ready for review August 20, 2024 09:26
@vblagoje
Copy link
Member Author

Closing in favour of #8256

@vblagoje vblagoje closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants