Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify embedding retriever version #7811

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: specify embedding retriever version #7811

merged 1 commit into from
Jun 6, 2024

Conversation

laffeychris
Copy link

Related Issues

Proposed Changes:

How did you test it?

Manual testing locally.

I would appreciate any pointers to where you might like me to include a test.

Notes for the reviewer

Checklist

@laffeychris laffeychris requested a review from a team as a code owner June 5, 2024 16:01
@laffeychris laffeychris requested review from shadeMe and removed request for a team June 5, 2024 16:01
@CLAassistant
Copy link

CLAassistant commented Jun 5, 2024

CLA assistant check
All committers have signed the CLA.

@laffeychris laffeychris marked this pull request as draft June 5, 2024 16:02
@laffeychris laffeychris marked this pull request as ready for review June 5, 2024 16:03
@shadeMe
Copy link
Collaborator

shadeMe commented Jun 6, 2024

Thanks for the PR! Could you add a release note briefly describing the change?

@sjrl
Copy link
Contributor

sjrl commented Jun 6, 2024

Hey @laffeychris thanks for the update! Being able to use revision also requires us to be at least using Sentence Transformers version 2.3.1 (actually it's 2.3.0, but let's include the patch version). So could you also update the pyproject.toml here

"sentence-transformers>=2.2.0", # See haystack/nodes/retriever/_embedding_encoder.py, _SentenceTransformersEmbeddingEncoder
and increase the version to 2.3.1?

@laffeychris laffeychris requested a review from a team as a code owner June 6, 2024 08:35
@laffeychris laffeychris requested review from dfokina and removed request for a team June 6, 2024 08:35
@shadeMe shadeMe merged commit 1c5fa02 into deepset-ai:v1.26.x Jun 6, 2024
57 checks passed
@sjrl sjrl linked an issue Jun 7, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot specify model version for SentenceTransformer embedding retriever
4 participants