Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vmsnapshot): add the ability to snapshot virtualmachines #347

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat(vmsnapshot): add the ability to snapshot virtualmachines #347

wants to merge 21 commits into from

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented Sep 5, 2024 •
edited
Loading

Description

New resource VirtualMachineSnapshot:

  1. CRD using kubebuilder, ru version
  2. Controller ensuring the consistency of the virtual machine and block devices when creating a snapshot (Freezing, no RestartAwaitingChanges, management via RequiredConsistency)
  3. Conditions VirtualMachineReady, VirtualMachineSnapshotReady
  4. Management of underlying secret and corresponding virtual disk snapshots.
  5. CacheSyncTimeout 10 min for all controllers

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@Isteb4k Isteb4k changed the title chore(api): set priority class for pods feat(vmsnapshot): create new controller Sep 5, 2024
@Isteb4k Isteb4k force-pushed the feat/vmsnapshot/controller branch 27 times, most recently from 87a5338 to e4f11d7 Compare September 10, 2024 13:59
@yaroslavborbat
chore(dev): fix pyroscope launch in script (#403)
f141f41 
fix pyroscope launch in script
Signed-off-by: yaroslavborbat <[email protected]>
@diafour
refactor(kubevirt): update to 1.3.1 (#372)
9e4f543 
Signed-off-by: Ivan Mikheykin <[email protected]>

* refactor(kubevirt): update to 1.3.1

- Port patches onto v1.3.1.
- Remove 002-fix-vcpu-count-issue and 004-backport-10001-from-upstream: these patches already in the upstream.
- Remove 003-macvtap-binding.patch as non-portable. It should be rewritten using Network Binding Plugins API. Keep using bridge mode by default.
- Use Go 1.22.7 to prevent recent CVEs.
- Update virt-operator rbac with new subresources.
- Add virt-tail to the virt-launcher image.
@Isteb4k Isteb4k force-pushed the feat/vmsnapshot/controller branch 6 times, most recently from 88a30c3 to 7f821fd Compare September 27, 2024 20:28
eofff and others added 2 commits September 30, 2024 10:22
@eofff
fix(vd,vi,cvi): fix vd uploader service creating (#409)
5445dc1 
The UID is now used for generating the name of ingress and service instead of the name of the original resource (vd, vi, cvi).

Signed-off-by: Valeriy Khorunzhin <[email protected]>
@universal-itengineer
refactor(core): edit go version in kubevirt and workspace file (#407)
f1e4893 
Fix go version in file WORKSPACE and root go.mod

Signed-off-by: Nikita korolev <[email protected]>
@Isteb4k Isteb4k force-pushed the feat/vmsnapshot/controller branch 6 times, most recently from cb8b6a9 to 04bc93d Compare September 30, 2024 15:30
LopatinDmitr and others added 2 commits September 30, 2024 22:53
@LopatinDmitr
fix(vmip): add validating ip address for VMIP with type 'Static' (#404)
ddb60cc 
Signed-off-by: dmitry.lopatin <[email protected]>
@eofff
chore(vm,vd,vi,cvi): set max name length to 128 (#410)
4bfaf66 
Setting the maximum length for the names of the following resources: vm, vd, vi, cvi
-------
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@Isteb4k Isteb4k force-pushed the feat/vmsnapshot/controller branch 5 times, most recently from 293890d to 8accbe6 Compare September 30, 2024 23:19
@Isteb4k Isteb4k marked this pull request as ready for review October 1, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat

@LopatinDmitr LopatinDmitr Awaiting requested review from LopatinDmitr

@diafour diafour Awaiting requested review from diafour

At least 1 approving review is required to merge this pull request.

Assignees

@Isteb4k Isteb4k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Isteb4k @diafour @LopatinDmitr @eofff @universal-itengineer @deckhouse-BOaTswain @hardcoretime @yaroslavborbat