Lock version of wkhtmltopdf-binary due to it's size
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fblupi
approved these changes
Jul 22, 2024
andreslucena
changed the title
wkhtmltopdf-binary due to it's size
andreslucena
requested changes
Jul 22, 2024
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the upgrade in #128, the gem
wkhtmltopdf-binaryhad an increase in size of about 150Mb. This made impossible to deploy the upgraded app to Heroku since the compressed app would be of over 500Mb.Here you can see the size of the different versions, and the huge increase between v0.12.6.6 and v0.12.6.7
https://rubygems.org/gems/wkhtmltopdf-binary/versions/0.12.6.6
This problem has also been referenced in their github, as we can see in this issue, and that comes from a prior versions.
The
wkhtmltopdf-binarydownloads loads of compressed binaries, and the uses the one for the platform it's running in. Another workaround would be to use a buildpack to remove the unnecessary zips before the compressing step in heroku. That way we could get to a smaller footprint, then having an improved deploy of the application.