Preserve color space when saving Arnold textures #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When saving a scene with textures the change of the fileTextureName attribute causes color space to change to the default value which is sRGB. With this fix, a correct color space is preserved.
|
Code reviewed, will plan to merge after I do some basic QA tests to confirm fix. Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving a scene with textures the change of the fileTextureName attribute causes color space to change to the default value which is sRGB. With this fix, a correct color space is preserved.
Maya version: 2020
How to replicate the bug:
What we can see: All textures have sRGB color space (depends on Maya settings, but sRGB is the default).
Expected: sRGB or RAW depending on the texture.
What is fixed in this pull request: Textures preserve their original color space and we can see in the texture node that it has the correct color space.