Fix converter for ndtiff using multicam #218
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ieivanov this is the PR I started trying to fix the convert to have iohub read the data with the additional axis. |
|
Thanks Ed - let's see if we can fix this problem at the source. I don't like that in this implementation we need to expand the array dimensions from 5D to 6D. In the meantime, I understand that this is helping you convert the data that's acquired with the intermediate fix we have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes handling ndtiffs written with mutlicam. When using multicam, the datasets have an extra axis that needs to be parsed to reshape the output array.