Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClusterOptions unit tests and SecurityOptions validation #19

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Add ClusterOptions unit tests and SecurityOptions validation #19

merged 2 commits into from
Sep 18, 2024

Conversation

Matt-Woz
Copy link
Contributor

@Matt-Woz Matt-Woz commented Sep 18, 2024 •
edited
Loading

Changes:

  • Added securityOption validation, ensuring only one of the trustOnly options are set
  • Added unit tests

Matt-Woz
Matt-Woz commented Sep 18, 2024
View reviewed changes
test/cluster.test.js Outdated Show resolved Hide resolved
@Matt-Woz Matt-Woz changed the title Add ClusterOptions unit tests Add ClusterOptions unit tests and SecurityOptions validation Sep 18, 2024
thejcfactor
thejcfactor approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Matt-Woz Matt-Woz merged commit 84c5cfc into couchbaselabs:main Sep 18, 2024
2 checks passed
@Matt-Woz Matt-Woz deleted the cluster_opts_unit_tests branch September 18, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejcfactor thejcfactor thejcfactor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt-Woz @thejcfactor