Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make inclusion to the test case list based on matching tags #317

Merged
merged 4 commits into from
Jun 19, 2024
Merged

feat: make inclusion to the test case list based on matching tags #317

merged 4 commits into from
Jun 19, 2024

Conversation

huberts90
Copy link
Collaborator

Use tags to narrow down test cases to those labeled with strings matching the regex passed as a config parameter.

@theseion theseion changed the title Make inclusion to the test case list based on matching tags feat: make inclusion to the test case list based on matching tags Jun 13, 2024
theseion
theseion requested changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I like it. Pretty much what I had in mind.

README.md Outdated Show resolved Hide resolved
cmd/run.go Outdated Show resolved Hide resolved
cmd/run.go Outdated Show resolved Hide resolved
cmd/run.go Outdated Show resolved Hide resolved
cmd/run.go Outdated Show resolved Hide resolved
runner/types.go Outdated Show resolved Hide resolved
runner/types.go Outdated Show resolved Hide resolved
runner/types.go Outdated Show resolved Hide resolved
utils/slice.go Outdated Show resolved Hide resolved
utils/slice_test.go Show resolved Hide resolved
Make inclusion to the test case list based on matching tags
a22bae5 
Use tags to narrow down test cases to those labeled with strings matching
the regex passed as a config parameter.
@huberts90 huberts90 marked this pull request as ready for review June 17, 2024 10:50
@huberts90 huberts90 requested a review from theseion June 17, 2024 10:50
theseion
theseion requested changes Jun 18, 2024
View reviewed changes
config/config_test.go Outdated Show resolved Hide resolved
config/types.go Outdated Show resolved Hide resolved
@theseion
Copy link
Collaborator

A small detail: please do not amend commits while reviews are ongoing. It makes reviewing much harder because it's unclear what changed between the original review and the following updates.

@huberts90 @theseion
Apply suggestions from code review
cee1875 
Rename `tag` with include_tags

Co-authored-by: Max Leske <[email protected]>
@huberts90
Copy link
Collaborator Author

huberts90 commented Jun 19, 2024 •
edited
Loading

A small detail: please do not amend commits while reviews are ongoing. It makes reviewing much harder because it's unclear what changed between the original review and the following updates.

Thanks for the head-up. I am accustomed to the Gitlab which manages to distinguish the code changes between version, if it is rebased.

@theseion theseion merged commit f19698d into coreruleset:main Jun 19, 2024
3 checks passed
@theseion
Copy link
Collaborator

Thanks!

@huberts90 huberts90 mentioned this pull request Jun 20, 2024
Open
3 tasks
@huberts90
Copy link
Collaborator Author

Refs #296

@huberts90 huberts90 deleted the hsiwik/tags branch June 20, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huberts90 @theseion