Misc small nits to CI and build #2573
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 8ca60c5 we use c/storage with devicemapper driver removed, so libdm_no_deferred_remove is no longer in use. Remove it. Signed-off-by: Kir Kolyshkin <[email protected]>
Instead of excluding just the *.gpg files, let's exclude directories containing those (and similar) files which should not be subjected to spell checker. This makes codespell run faster and fixes the following warning: > WARNING: Cannot decode file using encoding "utf-8": ./signature/simplesigning/testdata/private-keys-v1.d/A0E6EC3A2963DC2D19E9C24E4E6DD232E6BBE1CD.key > WARNING: Trying next encoding "iso-8859-1" Signed-off-by: Kir Kolyshkin <[email protected]>
Quite a few phony targets were not marked as such. Fix this. While at it, let's mark those individually, in place, so it's easier to remember and check. Signed-off-by: Kir Kolyshkin <[email protected]>
mtrmac
reviewed
Sep 19, 2024
| build: | ||
| go build $(BUILDFLAGS) ./... | ||
|
|
||
| $(MANPAGES): %: %.md | ||
| $(GOMD2MAN) -in $< -out $@ | ||
|
|
||
| .PHONY: docs |
There was a problem hiding this comment.
This one is not actually phony AFAICS: it’s a set of file dependencies with correct file dependencies on the sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.