-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle empty items in arrays and arraylike objects #75
Open
ninevra
wants to merge
11
commits into
concordancejs:main
Choose a base branch
from
ninevra:empty-array-items
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jul 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2b652fb - Browse repository at this point
Copy the full SHA 2b652fbView commit details
Commits on Jul 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 22c333d - Browse repository at this point
Copy the full SHA 22c333dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff9314d - Browse repository at this point
Copy the full SHA ff9314dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ddf8e8e - Browse repository at this point
Copy the full SHA ddf8e8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c4cea1 - Browse repository at this point
Copy the full SHA 6c4cea1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b2aa7a - Browse repository at this point
Copy the full SHA 5b2aa7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ad6803 - Browse repository at this point
Copy the full SHA 2ad6803View commit details
Commits on Jul 20, 2021
-
Use EmptyItem rather than empty primitive
Having an EmptyList descriptor type seems like a clearer description of the underlying data model than having an Empty primitive that can by construction only occur in PrimitiveItems.
Configuration menu - View commit details
-
Copy full SHA for c44c993 - Browse repository at this point
Copy the full SHA c44c993View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e4c74c - Browse repository at this point
Copy the full SHA 7e4c74cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e069360 - Browse repository at this point
Copy the full SHA e069360View commit details -
Configuration menu - View commit details
-
Copy full SHA for 608fe62 - Browse repository at this point
Copy the full SHA 608fe62View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.