Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable login on invalid form #81

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Disable login on invalid form #81

wants to merge 9 commits into from

Conversation

terror
Copy link
Member

@terror terror commented Aug 2, 2020

This disables the login functionality by button click and enter key until the form is valid. Issue: #38

ValerianClerc
ValerianClerc requested changes Aug 7, 2020
View reviewed changes
Copy link
Member

@ValerianClerc ValerianClerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice this until now but: currently you can submit the login without typing a password. Could you add a password rule that requires the password to be >= 6 characters long (that's what we currently enforce on the backend)

Other than that, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValerianClerc ValerianClerc Awaiting requested review from ValerianClerc

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terror @ValerianClerc @MohamedBeydoun