Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type def for MixOptions #347

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix type def for MixOptions #347

merged 1 commit into from
Nov 15, 2023

Conversation

jgerigmeyer
Copy link
Member

Fixes #346

MysteryBlokHed
MysteryBlokHed approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@MysteryBlokHed MysteryBlokHed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I’m not sure where I got that definition for MixOptions in the first place

@jgerigmeyer jgerigmeyer merged commit fa5898d into color-js:main Nov 15, 2023
5 checks passed
@jgerigmeyer jgerigmeyer deleted the fix-mix-types branch November 15, 2023 19:21
jgerigmeyer added a commit to oddbird/color.js that referenced this pull request Nov 16, 2023
@jgerigmeyer
Merge branch 'main' into formatting
6a6e7ee 
* main:
  Add CSS toGamut algorithm (color-js#344)
  Accept "Lightness" for lab space first channel name (color-js#348)
  Fix type def for MixOptions (color-js#347)
  Add CJS file to /fn entry and fix legacy builds (color-js#349)
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 3, 2024
Open
@Carolinewly Carolinewly mentioned this pull request Aug 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MysteryBlokHed MysteryBlokHed MysteryBlokHed approved these changes

@LeaVerou LeaVerou Awaiting requested review from LeaVerou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type definitions for mix options should also accept range options (hue, progression).
2 participants
@jgerigmeyer @MysteryBlokHed