107 enhancement secondary partners layout updates

[ogorman89]

This PR:

Resolves #107

Changes for desktop version of SecondaryPartners component only

• Changed the grid layout to something closer to 60-40 (text-box to logo-box)
• Cards still appear to be scaling correctly based on the largest card (ORDSN)
• Fixed a small issue that we rendering an empty <span> if there was no testimonialAuthor prop
  • Changed the other conditional renders to use the && short-circuit convention for consistency
• Design changes (based on my own opinion):
  • Changed some of the padding and alignment of the SecondaryPartners component
  • Centered the logo and text vertically; I think this makes the cards look better, but I can easily revert this if you guys like it better with some offset

---

Screenshots (if applicable):

Here's what it looks like with these changes

---

Future Steps/PRs Needed to Finish This Work (optional):

N/A

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
codepdx-website	⬜️ Ignored (Inspect)	Visit Preview		Feb 7, 2024 1:05am

[Jared-Krajewski]

request change for minor padding in comment . I am sorta partial to the logo being staggered, to me the white space within the card seems odd with it centered.. but If you want to change it I wont stop you either.

[Jared-Krajewski]

i think padding here can be 0% 10% 3% 10%, also the pt: '20px' can go.

const partnerGridStyle = {
  xs: 12,
  md: 6,
  display: 'flex',
  justifyContent: 'center',
  alignItems: 'center',
  flexDirection: 'column',
  pt: '20px' <----
};

[ogorman89]

@Jared-Krajewski

I pushed a commit to adjust the padding & alignment. I aligned items top, to be more like the figma file.

The CETI card looks a little off to me but not terrible there was no CETI in the initial figma mockup for comparison.

Note, I moved the 5% padding to the parent grid element. If I do the same padding on both child elements, they don't come out exactly equal. 🥳 I think this is fixable, but it seemed silly to waste too much time chasing it if padding the parent element works to make them the same size.

[andycwilliams]

@AJSterner did you intend to close this? I don't think this issue has been resolved.

Edit: Seems like this was closed by mistake. Reopening.