619/refactor image upload button #680
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leekahung
reviewed
Sep 21, 2024
There was a problem hiding this comment.
Small nitpick, could we have a small text right under the image icon (perhaps in white text) to let users know what it's for? For someone that's not tech-savvy, it's not immediately clear that I would need to click don't the image to change the image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Resolves #619
1. Removes "Choose/Remove Img" button on the Profile page and refactors it as a hover effect directly over the avatar
2. This approach more closely matches the way many services program the same functionality, so it ought to be intuitive enough for users
Screenshots (if applicable):
No photo uploaded:
No photo uploaded (plus hover):
With photo uploaded:
With photo uploaded (plus hover):
Additional Context (optional):
The goal is to make the Profile card less crowded-looking without sacrificing ease of use.
Future Steps/PRs Needed to Finish This Work (optional):