Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Overhaul #2

wants to merge 6 commits into from

Conversation

jamesthebrooks
Copy link
Contributor

Changes proposed in this pull request:

  • init setup on 11ty pages template
  • init home page migration
  • init styles migration and setup

security considerations

n/a

Copy link

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! I just commented on a fontawesome dependency listed that we don't need to use. Uninstall and rebuild the lock file and I think we should be good to go.

@@ -44,6 +44,7 @@
"rimraf": "^6.0.1"
},
"dependencies": {
"@fortawesome/fontawesome-free": "^6.6.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be using font awesome. If we need iconography, let's use USWDS's icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants