-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul #2
base: main
Are you sure you want to change the base?
Overhaul #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! I just commented on a fontawesome dependency listed that we don't need to use. Uninstall and rebuild the lock file and I think we should be good to go.
@@ -44,6 +44,7 @@ | |||
"rimraf": "^6.0.1" | |||
}, | |||
"dependencies": { | |||
"@fortawesome/fontawesome-free": "^6.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't be using font awesome. If we need iconography, let's use USWDS's icons.
Changes proposed in this pull request:
security considerations
n/a