Conmon: Run pages, fix compliance scan download #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pburkholder
changed the title
markdboyd
reviewed
Nov 4, 2022
| In total, you'll run three scans: | ||
| * For external sites (PaaS sites that do not require a GSA origin IP address) | ||
| * For internal sites (PaaS sites that do GSA origin IP address) | ||
| * For sites |
There was a problem hiding this comment.
Does this thought need to be finished?
Comment on lines
+67
to
+68
| * For internal sites (PaaS sites that do GSA origin IP address) | ||
| * For sites |
There was a problem hiding this comment.
Suggested change
| * For internal sites (PaaS sites that do GSA origin IP address) | |
| * For sites | |
| * For internal sites (PaaS sites that do require a GSA origin IP address) | |
| * For Pages sites (none of which require a GSA origin IP address) |
| @@ -71,6 +76,9 @@ The following steps are for the `external` scan (except as noted): | |||
| - In the ZAP-configured Firefox, log in to each site in the context list. | |||
| - For the **`external` context, use your "sandbox" identity**. VPN not needed. | |||
| - For the **`internal` context, use your Cloud Ops (GSA SecureAuth) identity**, and join the VPN | |||
| - For the **`pages` context, use your Cloud Ops identity** | |||
| - You should be non-privileged (e.g. site owner) user of Pages for the main app | |||
| - You shoudl be a _support_ user of Pages for the admin app | |||
There was a problem hiding this comment.
Suggested change
| - You shoudl be a _support_ user of Pages for the admin app | |
| - You should be a _support_ user of Pages for the admin app |
jameshochadel
force-pushed
the
pburkholder-patch-5
branch
from
0728f23
to
0f8b010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
security considerations
These steps are now too complex for a human to successfully execute on, and we need to invest in automating....