Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline updates #55

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Pipeline updates #55

merged 5 commits into from
Oct 12, 2023

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • Update pipeline to be self-flying
  • Remove triggers based on Terraform state YAML. We don't necessarily need or want this broker to redeploy when Terraform for a given environment (e.g. development) is redeployed. There is no use of Terraform outputs in the pipeline or configuration of the broker
  • Remove triggers based on defunct S3 bucket tracking the semver of deployed components
  • Update pipeline to use latest hardened containers and general-task iamge

security considerations

The main security facing change here is updating the pipeline to use the latest hardened containers including general-task

@markdboyd markdboyd requested a review from a team October 12, 2023 20:53
Copy link

@cweibel cweibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming all the secrets were moved to credhub to allow the self fly, this looks good to me

@markdboyd markdboyd merged commit 7b40294 into main Oct 12, 2023
1 check passed
@markdboyd markdboyd deleted the update-pipeline branch October 12, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants