Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloudfoundry page and api endpoint (proof of concept for local development) #52

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

echappen
Copy link
Contributor

@echappen echappen commented Mar 20, 2024

Changes proposed in this pull request:

  • Adds a demo page to the NextJS app that shows a list of your Cloud Foundry apps
  • Adds instructions for how to access CF data in a local dev environment

Note that this is for demo purposes only and does not persist the CF auth token. Since this is for demo/proof-of-concept purposes, automated tests haven't been added.

Also note that NextJS will cache API GET requests by default. You can bust the cache by hard-refreshing the page (command + shift + r). More info on caching is in the NextJS docs.

Looking for feedback on:

  • Would this be a good enough (for now) approach for local development?

Related to #48

Security considerations

  • The environment file is gitignored so that none of these CF variables enter source control

This does not persist the cf auth token in any way
@echappen echappen changed the title Add cloudfoundry page and api endpoints Add cloudfoundry page and api endpoints (proof of concept for local development) Mar 20, 2024
@echappen echappen changed the title Add cloudfoundry page and api endpoints (proof of concept for local development) Add cloudfoundry page and api endpoint (proof of concept for local development) Mar 20, 2024
Copy link
Contributor

@hursey013 hursey013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Especially appreciate the ongoing updates to the README ✨

@echappen echappen merged commit 1289e2d into main Mar 20, 2024
3 checks passed
@echappen echappen deleted the eoc/48 branch March 20, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants