Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextjs builds on pull request #35

Merged
merged 3 commits into from
Mar 7, 2024
Merged

nextjs builds on pull request #35

merged 3 commits into from
Mar 7, 2024

Conversation

jduss4
Copy link
Contributor

@jduss4 jduss4 commented Mar 6, 2024

Changes proposed in this pull request:

  • adds a build task to pull requests related to the nextjs app to test that it is building without any errors
  • adds a placeholder build id which at some point will be replaced with version tags or similar

Security considerations

None that I am aware of

@jduss4 jduss4 marked this pull request as ready for review March 6, 2024 19:23
sknep
sknep previously approved these changes Mar 6, 2024
View reviewed changes
echappen
echappen previously approved these changes Mar 7, 2024
View reviewed changes
.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
@jduss4 jduss4 dismissed stale reviews from echappen and sknep via 5b4b76d March 7, 2024 17:29
@jduss4 jduss4 merged commit 5f4e70a into main Mar 7, 2024
3 checks passed
@jduss4 jduss4 deleted the jvd/pr-build branch March 7, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echappen echappen echappen approved these changes

@sknep sknep sknep left review comments

@hursey013 hursey013 Awaiting requested review from hursey013

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jduss4 @echappen @sknep