Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nextjs assessment doc #34

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Add Nextjs assessment doc #34

merged 4 commits into from
Mar 7, 2024

Conversation

echappen
Copy link
Contributor

@echappen echappen commented Mar 6, 2024

Changes proposed in this pull request:

Closes #17

I've ported my rough notes on NextJS from our Engineering doc into the repo docs. I expect these notes to serve as the basis for an upcoming ADR for #28.

Looking for feedback from @hursey013 @sknep and @jduss4 on:

  • What is unclear or confusing?
  • Is there info I should've included (or something I should've prototyped) that I missed?

I feel like the Accessibility, Security, and Telemetry elements are the least thorough and provide more theoretical information than prototyped solutions. Testing, Routing, API handling are the most thorough.

@jduss4 If you want to fill out any notes for the Deployment section prior to merging this, please do.

Security considerations

None - documentation only

sknep
sknep previously approved these changes Mar 6, 2024
@sknep
Copy link
Contributor

sknep commented Mar 6, 2024

@apburnes no pressure, just thought you might like to eyeball this

Copy link
Contributor

@jduss4 jduss4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really impressed by everything you've been testing out. It's very thorough and easily understandable! Thanks!

nextjs/nextjs-site/_docs/assessment.md Outdated Show resolved Hide resolved
nextjs/nextjs-site/_docs/assessment.md Show resolved Hide resolved
nextjs/nextjs-site/_docs/assessment.md Show resolved Hide resolved
hursey013
hursey013 previously approved these changes Mar 7, 2024
Copy link
Contributor

@hursey013 hursey013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great work! Being able to get the entire team up to speed on the capabilities and details of Next.js before we begin building is so valuable - thank you!

@echappen echappen merged commit 690f6e9 into main Mar 7, 2024
2 checks passed
@echappen echappen deleted the eoc/17 branch March 7, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vet NextJS for our use
4 participants