-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curation for PyPI Pillow package #25983
base: master
Are you sure you want to change the base?
Conversation
@dangoor It looks like this PR has more than a curation in it. Did you mean to include a GitHub action, README update and updating the package.json? |
🤦 That's what I get for doing this manually (we were seeing issues with tooling not being able to open PRs for some reason). I'll fix this. |
As seen from all of the previous curations, Pillow is licensed HPND. See also [the license file](https://github.com/python-pillow/Pillow/blob/main/LICENSE).
711340e
to
b00afe9
Compare
OK, fixed! |
@dangoor Thanks for the update! I have had this discussion about other Pillow curations but I think this should be updated to MIT-CMU. Following the SPDX matching guidelines, this is a match. Also, SPDX uses Pillow as a reference to this license. What do you think? |
@capfei Interesting that it's a text match for MIT-CMU. In fact, it looks like the text is a match for MIT-CMU but not for HPND despite the fact that Pillow's license file says it's HPND I think you're right that the more correct license is MIT-CMU. |
It may be worth opening a pull request with the Pillow project to change the license file to remove the HPND sentence, since it's incorrect. |
@capfei - what should we do here? Technically, with the colored font on the SPDX templates, one could determine the pillow license (this portion) matches the HPND or MIT-CMU SPDX identifiers. I agree the MIT-CMU is the more complete SPDX identifier but then the pillow license calls itself HPND. Thoughts on opening an Issue or PR on this with pillow? |
Sorry for the long delay here. I have opened an issue with Pillow asking about either changing the license name to MIT-CMU or simply listing the SPDX identifer in the license file. HPND does not include the first paragraph in the matchable text so I would argue that it is not a match to HPND since the first paragraph looks to be a part of the license text. |
As seen from all of the previous curations, Pillow is licensed HPND.
See also the license file.