Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump badger dep from v3 to v4 #292

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sergiught
Copy link

🔧 Changes

In this PR we are bumping github.com/dgraph-io/badger from v3.2103.2 to v4.2.0 (Changelog).

Furthermore the Go version within the go.mod file was also updated from 1.17 to 1.22 (latest). As far as I can tell Badger v4 doesn't rely on features or standard library changes introduced after Go 1.17. This was done mainly to avoid running commands such as go mod tidy -go=1.16 && go mod tidy -go=1.17 for dependency bumps in the future.

🔬 Testing

Other than running go test -race ./... I executed the following as well:

go run main.go kv set myKey myValue
go run main.go kv get myKey
go run main.go kv list 
go run main.go kv reset
go run main.go kv sync
go run main.go kv delete myKey

No issues found.

image

I also ran govulncheck ./... with the following result:

=== Symbol Results ===

No vulnerabilities found.

Your code is affected by 0 vulnerabilities.
This scan also found 1 vulnerability in packages you import and 2
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.

Note

I'm more than happy to help out with bumping any other deps if there's an appetite, I was mostly interested in having the latest version of badger.

@sergiught sergiught marked this pull request as ready for review August 5, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant