Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move setup spec to user-configs branch #532

Merged
merged 10 commits into from
Jul 10, 2023
Merged

test: move setup spec to user-configs branch #532

merged 10 commits into from
Jul 10, 2023

Conversation

nullchilly
Copy link
Contributor

@nullchilly nullchilly commented Jul 7, 2023 •
edited
Loading

Related: #525

Perhaps we should move this chunk of test to an orphan branch?

@nullchilly nullchilly changed the title chore(tests): add more user configs p1 tests: add more user configs p1 Jul 7, 2023
@nullchilly nullchilly changed the title tests: add more user configs p1 test: add more user configs p1 Jul 7, 2023
@nullchilly nullchilly changed the title test: add more user configs p1 test: add more user configs part 1 Jul 7, 2023
@mrtnvgr mrtnvgr changed the title test: add more user configs part 1 ci(tests): add more user configs part 1 Jul 7, 2023
@nekowinston nekowinston self-requested a review July 7, 2023 17:06
@nekowinston
Copy link
Contributor

nekowinston commented Jul 7, 2023 •
edited
Loading

I'm all for using an orphan branch (e.g. user-configs) for this.

We can keep the file in tests/setup_spec.lua, then run tests on main, use git checkout user-configs tests/setup_spec.lua before we actually run the tests. As long as we don't commit back onto the main branch in the action, this will keep the branches apart cleanly.

@mrtnvgr test: is a type in Conventional Commits, changing this to ci(tests): wasn't necessary.

@mrtnvgr mrtnvgr changed the title ci(tests): add more user configs part 1 test: add more user configs part 1 Jul 8, 2023
nekowinston
nekowinston approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@nekowinston nekowinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out it wasn't as easy as simply running git checkout user-configs tests/setup_spec.lua in GitHub actions, but we got there in the end 🙂

@nullchilly nullchilly changed the title test: add more user configs part 1 test: move setup spec to user-configs branch Jul 10, 2023
@nullchilly nullchilly merged commit bf561b5 into main Jul 10, 2023
10 checks passed
@nullchilly nullchilly deleted the configs branch July 10, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekowinston nekowinston nekowinston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nullchilly @nekowinston @mrtnvgr