Bugfix in register_base.rs #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankjannis
force-pushed
the
patch-1
branch
2 times, most recently
from
957ac08
to
3827c05
Compare
|
@frankjannis Thank you for your contribution(And sorry for my late reply). The change itself seems nice. Would you rebase the branch with the current master? I think #181 fixed the CI failure. |
Function parameters were out of order
|
@frankjannis Sorry, I missed your update. LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function parameters were out of order
test_all.shis passed.fix #{ISSUE_NUMBER}if the corresponding issue exists.## Changelogsection. If the change is for only internal use, please writeNoneto the section.Changelog
Bugfix in register_base.rs::with_cache_or_read: Function parameters were out of order.