Implement fcntl_getlk
#1077
Open
Implement fcntl_getlk
#1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al8n
force-pushed
the
main
branch
3 times, most recently
from
0ead0de
to
600f50c
Compare
notgull
suggested changes
Jun 17, 2024
Comment on lines
+1102
to
+1109
| l_type: F_WRLCK as _, | ||
|
|
||
| // When `l_len` is zero, this locks all the bytes from | ||
| // `l_whence`/`l_start` to the end of the file, even as the | ||
| // file grows dynamically. | ||
| l_whence: SEEK_SET as _, | ||
| l_start: 0, | ||
| l_len: 0, |
There was a problem hiding this comment.
It might be nice to give the user control over these fields via parameters to the function call.
There was a problem hiding this comment.
I agree that it'd be nice to expose this functionality, however the existing fcntl_lock doesn't currently give the user control over these flags either, so this is ok for now.
|
Overall this looks good, though there are some test failures that look relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #1076