Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow + in repo names #2908

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Allow + in repo names #2908

merged 3 commits into from
Oct 1, 2024

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Oct 1, 2024

Bazel 8 uses + as the separator for segments of canonical repo names, whereas Bazel 7 uses ~ or + depending on the value of --incompatible_use_plus_in_repo_names.

@fmeum
Copy link
Contributor Author

fmeum commented Oct 1, 2024

CC @Wyverald

@fmeum fmeum force-pushed the bazel-8 branch 2 times, most recently from 6621c29 to 8141702 Compare October 1, 2024 08:58
Bazel 8 uses `+` as the separator for segments of canonical repo names, whereas Bazel 7 uses `~` or `+` depending on the value of `--incompatible_use_plus_in_repo_names`.
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion added this pull request to the merge queue Oct 1, 2024
Merged via the queue into bazelbuild:main with commit 9390eba Oct 1, 2024
4 checks passed
@fmeum fmeum deleted the bazel-8 branch October 1, 2024 14:19
@fmeum
Copy link
Contributor Author

fmeum commented Oct 1, 2024

@illicitonion Could we get a release this week? Bazel 8rc1 will come out on Monday and needs this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants