Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix platform validation for wasm32-wasip1 target #2894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

c16a
Copy link

@c16a c16a commented Sep 23, 2024

This fix validation errors for the new wasm32-wasip1 target. The older wasm32-wasi is already covered. Fixes #2782

@c16a
Copy link
Author

c16a commented Sep 23, 2024

@UebelAndre can you please review this?

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, thanks!

@c16a
Copy link
Author

c16a commented Sep 24, 2024

@UebelAndre seems like the build failed due to an intermittent network issue. Can you please help re-trigger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New wasi targets are invalid
2 participants