Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support protoc-gen-prost-serde in prost_toolchain #2646

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mrmeku
Copy link

@mrmeku mrmeku commented May 9, 2024

protoc-gen-prost-serde is a protoc plugin that generates serde serialization implementations that follow the conventions of protobuf-JSON. Prost does not have JSON bindings itself, so this plugin adds them. Since it is augmenting the structs generated by prost itself, it needs to be part of the same crate which is why I've added it to the existing prost_toolchain

@mrmeku mrmeku force-pushed the mrmeku-prost-json branch 3 times, most recently from 8324f00 to c22f90c Compare May 9, 2024 18:05
mrmeku added 2 commits May 9, 2024 14:00
This allows users to add serde support for their
generated prost proto bindings.
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks reasonable, thanks!

Two questions:

  1. Can you add a test or example which shows this working, so that we don't break it in the future?
  2. Why is the rustfmt stuff getting removed? It feels like it should probably still stay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants