Deduplicate additional exec constraint logic #23803
Open
+206
−212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Configurability
fmeum
force-pushed
the
23802-prefactor
branch
from
ff7dda1
to
99a8a37
Compare
katre
requested changes
Sep 30, 2024
src/main/java/com/google/devtools/build/lib/skyframe/toolchains/ToolchainContextUtil.java
Show resolved
Hide resolved
fmeum
force-pushed
the
23802-prefactor
branch
from
99a8a37
to
1122d1e
Compare
katre
approved these changes
Sep 30, 2024
katre
added
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize the logic around
exec_compatible_within a single place to simplify the introduction ofexec_group_compatible_with.Work towards #23802