Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include apparent names of deps in bazel mod JSON output #23787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 27, 2024

This allows IDEs to query for the direct dependencies of the root module as well as how they can refer to them from the point of view of the root module.

Also always emit name and version so that consumers don't have to know how to parse module keys.

Work towards #22691

@fmeum
Copy link
Collaborator Author

fmeum commented Sep 27, 2024

@bazel-io fork 7.4.0

@fmeum fmeum force-pushed the 22691-bazel-mod-apparent-name branch from e0a4ce7 to 7bb1ad2 Compare September 27, 2024 12:23
@fmeum fmeum marked this pull request as ready for review September 27, 2024 12:25
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Sep 27, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 27, 2024

@meteorcloudy @Wyverald I'm planning to pair this with another PR that allows --override_repository to add new repos even with --noenable_workspace, which then use the main repos mapping.

@fmeum fmeum force-pushed the 22691-bazel-mod-apparent-name branch from 7bb1ad2 to 9f00f77 Compare September 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant