Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip disallow empty glob #15327

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Flip disallow empty glob #15327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fc1bc6
Flip disallow empty glob
limdor Apr 24, 2022
5d2cea6
Be explicit about allowing empty glob
limdor Jan 16, 2024
7b11daf
Add a bzl file to prevent having empty globs
limdor Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ public final class BuildLanguageOptions extends OptionsBase {

@Option(
name = "incompatible_disallow_empty_glob",
defaultValue = "false",
defaultValue = "true",
category = "incompatible changes",
documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS},
Expand Down Expand Up @@ -902,7 +902,7 @@ public StarlarkSemantics toStarlarkSemantics() {
"+incompatible_depset_for_libraries_to_link_getter";
public static final String INCOMPATIBLE_DISABLE_TARGET_PROVIDER_FIELDS =
"-incompatible_disable_target_provider_fields";
public static final String INCOMPATIBLE_DISALLOW_EMPTY_GLOB = "-incompatible_disallow_empty_glob";
public static final String INCOMPATIBLE_DISALLOW_EMPTY_GLOB = "+incompatible_disallow_empty_glob";
public static final String INCOMPATIBLE_DISALLOW_STRUCT_PROVIDER_SYNTAX =
"-incompatible_disallow_struct_provider_syntax";
public static final String INCOMPATIBLE_PACKAGE_GROUP_HAS_PUBLIC_SYNTAX =
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/com/google/devtools/build/lib/packages/util/MockCcSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,8 @@ protected void setupRulesCc(MockToolsConfig config) throws IOException {
"cc/cc_toolchain_config_lib.bzl",
"cc/find_cc_toolchain.bzl",
"cc/toolchain_utils.bzl",
"cc/private/rules_impl/BUILD")) {
"cc/private/rules_impl/BUILD",
"cc/private/rules_impl/native.bzl")) {
try {
config.create(
"third_party/bazel_rules/rules_cc/" + path,
Expand Down
2 changes: 1 addition & 1 deletion src/test/shell/bazel/runfiles_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ function test_switch_runfiles_from_enabled_to_disabled {
sh_binary(
name = "cmd",
srcs = ["cmd.sh"],
data = glob(["data-*"]),
data = glob(["data-*"], allow_empty = True),
)
genrule(
name = "g",
Expand Down