Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate build tags as both true and false #1938

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

patrickmscott
Copy link

Gazelle already iterates over all supported os/arch combos to include go files. This is similar but expanded to custom tags. When adding a new build tag, we create a copy with the tag set to true and append to the original. This means that build tag evaluation will grow exponentially.

Fixes #1262

What type of PR is this?

Feature

What package or component does this PR mostly affect?

language/go

What does this PR do? Why is it needed?

It changes the behavior of build_tags to defer evaluation to build time. Instead of assuming the tag is always true, it treats the tag as both true and false when evaluating tags for a file.

Which issues(s) does this PR fix?

Fixes #1262

Other notes for review

Copy link

google-cla bot commented Sep 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Gazelle already iterates over all supported os/arch combos to include go
files. This is similar but expanded to custom tags. When adding a new
build tag, we create a copy with the tag set to true and append to the
original. This means that build tag evaluation will grow exponentially.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_tags does not generate conditional build files
1 participant